Update ACL tests and modify JedisPool tests #2325

sazzad16 · 2020-12-23T14:54:52Z

Test ACL with non-default user for standalone Redis instance (Jedis, Jedis with SSL, JedisPool)
Removed Jedis with ACL tests where ACL feature was not being used and will not bring anything new even if used
Removed JedisPool with ACL tests where ACL feature was not being used and will not bring anything new even if used
Modify JedisPool (with/without ACL) tests
Used try-with-resources in JedisPool (with/without ACL) tests
Added a test related to issue JedisDataException when trying to connect with ACL user: null user is mistakenly used #2318 and PR Fixes missing parameters in JedisPool constructor #2319
Added two minimal JedisPool constructor with user and password params (also testing those)

src/test/java/redis/clients/jedis/tests/JedisPoolTest.java

sazzad16 added 3 commits December 23, 2020 19:27

Test ACL with non-default user (standalone Redis instance)

b51ca26

Modify JedisPool (w/wo ACL) tests

5ed4db4

Modify Jedis (w/wo ACL) tests

948f50a

sazzad16 added the wait for more reviews label Dec 23, 2020

sazzad16 added this to the 3.4.1 milestone Dec 23, 2020

sazzad16 requested a review from gkorland December 23, 2020 14:54

sazzad16 modified the milestones: 3.4.1, 3.5.0 Dec 23, 2020

Test related to issue redis#2318 and PR redis#2319

342aa47

sazzad16 marked this pull request as draft December 23, 2020 15:03

sazzad16 added 2 commits December 23, 2020 21:20

Update AccessControlListCommandsTest

406dfa1

Adding one test in JedisPoolWithCompleteCredentialsTest

96312ea

sazzad16 force-pushed the acl-tests branch from 8910513 to 96312ea Compare December 23, 2020 15:40

sazzad16 marked this pull request as ready for review December 23, 2020 15:56

gkorland suggested changes Dec 24, 2020

View reviewed changes

src/test/java/redis/clients/jedis/tests/JedisPoolTest.java Show resolved Hide resolved

src/test/java/redis/clients/jedis/tests/JedisPoolTest.java Outdated Show resolved Hide resolved

use try-with-resources in JedisPool tests

b9bf1ac

sazzad16 force-pushed the acl-tests branch from 787e9a5 to b9bf1ac Compare December 24, 2020 11:24

gkorland added 2 commits December 24, 2020 16:01

Merge branch 'master' into acl-tests

f43c5c9

Merge branch 'master' into acl-tests

4753cbf

gkorland approved these changes Dec 24, 2020

View reviewed changes

sazzad16 added ready to merge and removed wait for more reviews labels Dec 24, 2020

sazzad16 changed the title ~~Update ACL tests~~ Update ACL tests and modify JedisPool tests Dec 24, 2020

sazzad16 merged commit 1a9de79 into redis:master Dec 24, 2020

sazzad16 deleted the acl-tests branch December 24, 2020 15:39

sazzad16 removed the ready to merge label Dec 24, 2020

sazzad16 mentioned this pull request Dec 28, 2020

Use user other than default user in ACL tests #2320

Open

dependabot bot mentioned this pull request Mar 15, 2021

Bump jedis from 3.4.0 to 3.5.1 in /core gesellix/testcontainers-java#353

Closed

dependabot bot mentioned this pull request Mar 16, 2021

Bump jedis from 3.3.0 to 3.5.2 jeremywall/rolling-rate-limiter-java#9

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update ACL tests and modify JedisPool tests #2325

Update ACL tests and modify JedisPool tests #2325

sazzad16 commented Dec 23, 2020 •

edited

Loading

Update ACL tests and modify JedisPool tests #2325

Update ACL tests and modify JedisPool tests #2325

Conversation

sazzad16 commented Dec 23, 2020 • edited Loading

sazzad16 commented Dec 23, 2020 •

edited

Loading